Skip to content

Conversation

therealmate
Copy link
Contributor

Fixes #1293

@jacobgkau jacobgkau requested review from a team October 2, 2025 03:42
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this change, after removing a Pop!_OS 24.04 user from the sudo group and adding it to a new wheel group, changing the hostname ("Device name" setting on the About page) didn't work. After this change, I'm able to change the hostname while being part of wheel and not sudo.

Note that I didn't actually change the sudoers group from sudo to wheel during this test (and was thus unable to run sudo commands on the terminal), so this isn't actually checking if the user has root permissions, it's only checking if they're part of one of these group names. But since both of these names are de-facto reserved for sudoers use, and new groups can't be added without root privileges in the first place (at least on Pop!_OS), this doesn't seem like a problem. (If it was a security concern for Pop!_OS, then non-Pop!_OS distros using group names other than sudo would already have the same problem right now.)

@mmstick mmstick merged commit 6ebdcdc into pop-os:master Oct 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fedora] Polkit rules reference the wrong sudoers group
4 participants